Hey everyone!
New update is live. More players lead to more interesting issues. Let's look at some of them.
A player reported that all of his vehicles disappeared. He provided a save file and it truly had no vehicles. Even resetting the filter does nothing. If there would not be a save file, I would not believe that this can happen. After some minutes of debugging, it turned out that there were spaces in the search bar and no vehicle had so mane spaces in their search specifications. So for this, I had to make a clear filters button to also clear the search bar and trim strings front and ends before filtering results.
Then there were several reports of vehicles inventory going negative. This resulted in the game allowing to buy even more vehicles because I only checked if inventory was 0, not less and 0.
This is not a bug, but an expected issue/feature. If passengers are not boarding, but vehicles are always full, then you need to look deeper why destinations are not fulfilled. Vehicles first board passengers who are using this city as an indirect stop, then board those who are going home, and only then board passengers that originate from the city itself. It is made so that because otherwise indirect passengers would just pile up. If a city has a huge amount of indirect passengers already, then vehicles will not deliver further passengers there as well. Passengers will choose another route with other cities in between.
Finally, some were reporting that passengers were not boarding vehicles even with direct paths. After further inspection, it was an integer overflow bug. When a vehicle tries to pick up passengers, it registers its route distance. If this distance is too long, then passengers will not board. It can be too long in general, or just the best route available is just so much shorter. But to keep things dynamic, after the best route vehicle leaves its last registered best path keeps increasing, allowing others to pick up its passengers if it takes too long to come back. It appears that there was a chance for this value to increase indefinitely and at some point overflow to a negative one. That resulted in making the best vehicle only one who can transfer passengers, even if later you build a shorter path vehicle. Simple checks fixed it. The lesson here is that redundant checks are better, but my brain is always screaming PERFORMANCE! And I avoid redundant checks because it is my code and I remember what to avoid. But I was proved wrong. So more checks from now on.
Bugfixes:
- Fixed vehicles not boarding in certain cases
- Fixed being able to have a negative vehicles inventory
- Fixed all transport vehicles being hidden after adding spaces in the search bar
- Fixed passengers boarding when a route is non-cyclic and vehicle needs to come back before their destination
- Fixed Steam Deck UI scroll also zooms in/out
- Fixed being able to upgrade vehicles that are out of stock
Changes:
- Made explorer filters reset button to also reset the search bar
- Made 0 inventory label to show in red
- Removed cents display
- Updated Hull translation from 船体 to ハル
Additions:
- Added vehicle route cities to vehicle search instructions
Keep the feedback coming!