Hello everyone. I'm not feeling well/functional today, so here's a few remaining bugfixes for PhotonDust to get these out, but not much else. I don't want these to be held up.
These should pretty much fix up any last issues that I'd consider blockers for finalizing PhotonDust. I'll push a prerelease build with the same fixes in a bit - if all is good, we'll probably remove the Legacy particle system in the next build or two.
Optimizations:
- Switched Message content serialization to System.Text.Json
Fixes:
- Added validation to Min/Max sequence count for SequenceRibbonSplitter (based on report by @nytra, issue #3663)
-- This prevents invalid values from breaking PhotonDust
-- If MinSequenceCount is larger than MaxSequenceCount, then it'll be always used
- Fixed regression causing TrailLifetimeFromSizeInitializer module being always on for converted trails, resulting in incorrect lengths (reported by @modernballoonie, issue #3701)
- Fixed ConeEmitter not respecting DirectionTransformMode for RadialUniform directions, resulting in different particle velocities for legacy content (based on report by @nytra, issue #3705)
- Fixed trails from legacy particle systems having slightly different color when using Min/Max trail color (reported by @krzeszny, @joshtiger, issue #3488)
-- This is due to legacy system converting those colors as Linear and then Unity particle system reinterpreting them as sRGB
- Fixed legacy particle systems with render transform override that are scaled to zero by default not rendering after conversion (based on report by @badhaloninja, issue #3531)
-- This is done by disabling the UseSystemLocalScale when this transform override is detected - with PhotonDust, the particle scaling is computed only once during simulation - render transform override cannot update the individual particle sizes